fix(vmm): Forbid host API listening on non-vsock addresses #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host API is designed for CVM-to-host communication via vsock only. When users accidentally configure TCP or Unix socket addresses, it silently falls back without proper error, making troubleshooting difficult. Changes: - Add validation in HostApiConfig to ensure address starts with 'vsock:' - Validate config at startup and fail fast with clear error message - Remove TCP fallback code from run_host_api since only vsock is supported Fixes #417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The host API is designed for CVM-to-host communication via vsock only. When users accidentally configure TCP or Unix socket addresses, it silently falls back without proper error, making troubleshooting difficult.
Changes
HostApiConfigto ensure address starts withvsock:run_host_apisince only vsock is supportedError Message
If a user configures a non-vsock address like
127.0.0.1:Fixes #417