Open
Conversation
SaloEater
suggested changes
Sep 4, 2025
| */ | ||
| public void setKeyProgress(String key, ResourceType rt, float value) { | ||
| if (key == null || key.isEmpty()) return; | ||
| var byKey = keyProgress.computeIfAbsent(rt, __ -> new java.util.HashMap<>()); |
There was a problem hiding this comment.
Better to extract this line into a separate method because it repeats several times during this file and changes all other same occurences
It should be something like
Suggested change
| var byKey = keyProgress.computeIfAbsent(rt, __ -> new java.util.HashMap<>()); | |
| var byKey = getKeyProgressOrCreate(rt); |
| * Set the exact cursor value for a specific key/resource. | ||
| * If value <= EPS the key entry is removed. | ||
| */ | ||
| public void setKeyProgress(String key, ResourceType rt, float value) { |
There was a problem hiding this comment.
This has no usage, maybe you should remove it?
| var unit = Load.Unit(player); | ||
| if (unit != null) { | ||
| // Iterate only active keys per resource | ||
| for (var rt : com.robertx22.mine_and_slash.saveclasses.unit.ResourceType.values()) { |
There was a problem hiding this comment.
Use an import instead
Suggested change
| for (var rt : com.robertx22.mine_and_slash.saveclasses.unit.ResourceType.values()) { | |
| for (var rt : ResourceType.values()) { |
| if (procs > 0) { | ||
| spec.onProc(sp, procs); | ||
| spec.startCooldown(unit, now); | ||
| if (spec.resetOnProc()) { |
There was a problem hiding this comment.
To match names of other methods
Suggested change
| if (spec.resetOnProc()) { | |
| if (spec.dropProgressOnProc()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.