Skip to content

Address PR review feedback: fix markdown tables, typo, and vehicle cleanup#8

Closed
Copilot wants to merge 1 commit into
Feature/API_metricsfrom
copilot/sub-pr-6-again
Closed

Address PR review feedback: fix markdown tables, typo, and vehicle cleanup#8
Copilot wants to merge 1 commit into
Feature/API_metricsfrom
copilot/sub-pr-6-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 18, 2026

Addresses all review comments from PR #6, fixing markdown rendering issues, a typo, and adding proper resource cleanup to the probe script.

Markdown table fixes (docs/metrics_catalog.md)

  • Removed extra empty columns from Vehicle State and Collision Event tables
  • Fixed broken inline code blocks split across columns (e.g., vehicle.speed and event.intensity)
  • Standardized "computed magnitude" annotation format

Typo correction (src/cot/carla_client.py)

  • Fixed "dependant" → "dependent" in comment

Vehicle cleanup (src/scripts/probe_world_and_vehicle.py)

  • Added try/finally block to destroy spawned vehicles, preventing actor accumulation across runs
  • Added synchronous mode detection to use world.tick() vs world.wait_for_tick() appropriately
try:
    v, spawned = get_or_spawn_vehicle(world)
    # ... probe metrics ...
finally:
    if spawned and v is not None and getattr(v, "is_alive", False):
        v.destroy()

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add metrics inventory and probe script for Python API Address PR review feedback: fix markdown tables, typo, and vehicle cleanup Feb 18, 2026
Copilot AI requested a review from Dumpy250 February 18, 2026 05:40
@Dumpy250 Dumpy250 closed this Feb 18, 2026
@Dumpy250 Dumpy250 deleted the copilot/sub-pr-6-again branch March 4, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants