Conversation
… keyword names in get_IFW_metadata.
…s and enable parallel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Security hardening and cleanup for archive extraction, HTTP retry behavior, and build configuration.
Type of Change
Changes
_save_response_to_file()to prevent directory escape_is_safe_path()check and optionalmax_sizelimit in_extract_archive()allowed_methods={"GET", "POST"}toRetry()so POST-based search endpoints are retried on 429/5xx errorsget_IFW_metadatautils.httpmodule andALLOWED_METHODS— Dead code that duplicatedUSPTOConfig._create_session()with different settingsparallel = autoTesting
New tests:
TestSaveResponseToFilePathTraversal— path traversal in download filenamesTestExtractArchive— path traversal, zip bomb, and directory handling in archivesTestExtractArchiveSymlinks— symlink/hardlink skipping for tar and ziptest_session_retries_post_requests— POST included in retry allowed methodsChecklist
Related Issues
N/A
Additional Notes
utils.httpmodule removed entirely —create_session()andparse_response()were unused by any client