[Cherry-pick] DYN-10493: Fix crash in Getting Started guided tour#17113
Conversation
(cherry picked from commit d7bd3aa)
|
|
Successfully Rerun: Looks like Smoke Tests never run - Rerunning now: https://c007.cloudbees-ci.autodesk.com/job/DYNCI/job/Dynamo/job/DynamoAGTTests/job/smoke/204/ |
|
Smoke Test failed 3 times in a row 20:52:29 C:\Jenkins\workspace\YNCI_Dynamo_DynamoAGTTests_smoke\repositories\Dynamo\src\Libraries\DynamoUnits\UnitsCore.csproj(46,5): error MSB3030: Could not copy the file "C:\Users\CDABuildGuy.nuget\packages\forgeunits.net\5.3.2\lib\net6.0\ForgeUnitsManaged.dll" because it was not found. Odd that this just started, but it would seem unrelated to this cherry picked code change Merging and will inform QA of the Smoke Test failures |



Cherry-pick of #17111 to
RC4.1.1_masterPurpose
Fixes DYN-10493: Dynamo crashes when clicking "Start Tour" on the Getting Started guided tour (Learning tab). The crash occurs on the transition from the Welcome popup to step 2 ("nodes").
Root cause:
GuidesValidationMethods.HighlightPortcallsItemContainerGenerator.ContainerFromItemto locate the WPF container for a port, then passes the result toCreateRectangle.ContainerFromItemcan returnnullwhen theItemsControlhasn't generated containers yet. This is a timing race exposed by PR #16883 (DYN-7760, Feb 17 2026), which added synchronous WebView2 extension-closing before tour startup — shifting the dispatcher queue state enough to delay container generation past the point whereHighlightPortreads it. The resultingnullreachedNameScope.SetNameScopeinsideCreateRectangle, which throwsArgumentNullException("dependencyObject").Key changes:
mainGridinHighlightPort(GuidesValidationMethods.cs) — skips the port highlight rather than crashing if the container isn't ready. The tour continues without the visual effect.Regression introduced in: PR #16883 (DYN-7760, Feb 17 2026)
Not reproducible in: 4.0.2 and older
Fix targets:
master, cherry-pick to4.1.1Full investigation: DYN-10493 DynaNote (Autodesk internal)
Declarations
Release Notes
Fixed a crash that occurred when clicking "Start Tour" on the Getting Started guided tour (Learning tab).
Reviewers
(FILL ME IN)
FYIs
(FILL ME IN, Optional)