FATES Performance Optimizations and Patch(PFT) level Shared Memory Paralellism#8143
Draft
rgknox wants to merge 32 commits into
Draft
FATES Performance Optimizations and Patch(PFT) level Shared Memory Paralellism#8143rgknox wants to merge 32 commits into
rgknox wants to merge 32 commits into
Conversation
…to only trigger if nclumps>1
Contributor
Author
|
This is a WIP. Currently coordinating with @peterdschwartz so that these changes play nice with his openacc changes. Collaborators: @bishtgautam @peterdschwartz @ckoven |
rgknox
commented
Mar 5, 2026
| @@ -297,7 +303,7 @@ subroutine get_clump_bounds_new (n, bounds) | |||
| !write(iulog,*) 'SPM omp debug decompMod 1 ', & | |||
| !OMP_GET_NUM_THREADS(),OMP_GET_MAX_THREADS(),OMP_GET_THREAD_NUM() | |||
|
|
|||
| if ( OMP_GET_NUM_THREADS() == 1 .and. OMP_GET_MAX_THREADS() > 1 )then | |||
| if (.not.use_fates .and. ( OMP_GET_NUM_THREADS() == 1 .and. OMP_GET_MAX_THREADS() > 1 ))then | |||
Contributor
Author
There was a problem hiding this comment.
change this logic to be if nclumps>1
Contributor
Author
|
This PR must follow FATES PR: |
5 tasks
Member
|
@rgknox if this is a work in progress, convert it to a draft PR. |
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes introduces two features aimed improving performance of the FATES model: