create eamxx GW atm process#8319
Open
whannah1 wants to merge 61 commits into
Open
Conversation
Contributor
|
bartgol
reviewed
Apr 24, 2026
Contributor
bartgol
left a comment
bartgol
left a comment
There was a problem hiding this comment.
Big PR! I did not really look at the impl folder, as I don't know enough there (I'll defer to Jim).
The infrastructure glue seems ok though. Just one doubt on a team reduction.
Comment on lines
+85
to
+89
| Kokkos::View<Real*, Kokkos::HostSpace> pref_int("pref_int", hyai.size()); | ||
| Kokkos::parallel_for("calculate_pref_int", | ||
| Kokkos::RangePolicy<Kokkos::DefaultHostExecutionSpace>(0, hyai.size()), | ||
| KOKKOS_LAMBDA (const int k) { | ||
| pref_int(k) = PC::P0.value * hyai(k) + PC::P0.value * hybi(k); |
Contributor
Author
Member
There was a problem hiding this comment.
@whannah1 , no. The bot is right, you are mixing host and device usage here. I don't see any reason not to use the normal device for pref_int.
Contributor
Author
There was a problem hiding this comment.
I (claude) refactored this to remove the host space variables - I ran a CPU test and everything worked. I haven't done a GPU test yet.
Comment on lines
+130
to
+134
| const auto team_policy = TPF::get_default_team_policy(m_ncol, nlev_mid_packs); | ||
| const auto scan_policy = TPF::get_thread_range_parallel_scan_team_policy(m_ncol, nlev_mid_packs); | ||
| // Use one workspace with the biggest size or use two, one for pver, one for pver*2*pgwv? | ||
| WSM wsm( (m_nlev+1)*m_npgw, 9, team_policy); | ||
| //---------------------------------------------------------------------------- |
Comment on lines
+79
to
+83
| static bool s_common_init_constructed = false; | ||
| if (!s_common_init_constructed) { | ||
| new (&s_common_init) GwCommonInit(); | ||
| s_common_init_constructed = true; | ||
| } |
Member
|
Is this actually ready for review? Needs a description added. Else change it to draft. |
Member
|
Shold this be draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.