Revert indexing change for wave frequency arrays#8336
Merged
Conversation
erinethomas
approved these changes
Apr 29, 2026
Contributor
erinethomas
left a comment
erinethomas
left a comment
There was a problem hiding this comment.
I fully support reverting the indexing back to the default behavior.
Contributor
|
does this need to be in for the 3.2 tag? |
Contributor
Author
|
Yes, I believe it should be. |
Contributor
Author
|
@rljacob, this is ready when you get a chance. |
rljacob
added a commit
that referenced
this pull request
May 5, 2026
This PR reverts a change to the indexing for frequency arrays from d7607ce This change was meant to fix out of bounds errors for debug gnu errors, but resulted in divide by zero issues. [BFB] for cases without waves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts a change to the indexing for frequency arrays from d7607ce
This change was meant to fix out of bounds errors for debug gnu errors,
but resulted in divide by zero issues.
[BFB] for cases without waves