Update default MALI calving parameter defaults for Greenland meshes used in E3SM simulations#8346
Conversation
For Greenland meshes used in coupled e3sm simualtions, set default mali calving parameters differently than for other meshes or simulation types.
stephenprice
added
the
MPAS-albany-landice
|
@matthewhoffman has suggested that "PB1982" should always be the default value for the setting of I'm not 100% sure the if construct syntax here is entirely correct or optimal, but I can at least confirm that it worked as desired for the 3 grids that I tested. |
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
@stephenprice , thanks for opening this for enshrining the calving settings you've been successfully running with. I have a few comments below, some related to the messiness of the format of these bld files, and two checking on what might be inconsistent settings.
| add_default($nl, 'config_flowParamA_calculation'); | ||
| } | ||
| add_default($nl, 'config_sia_tangent_slope_calculation'); | ||
| add_default($nl, 'config_flowParamA_calculation'); |
There was a problem hiding this comment.
This set of changes (this line and the additions above) aren't needed. Instead, change the default value directly in components/mpas-albany-landice/bld/namelist_files/namelist_defaults_mali.xml. That new default will be safe for all MALI configurations in E3SM.
| add_default($nl, 'config_calving'); | ||
| if ($GLC_GRID eq 'mpas.gis4to40km' || $GLC_GRID eq 'mpas.gis1to10kmR2') { | ||
| add_default($nl, 'config_calving', 'val'=>"crevasse_depth"); | ||
| add_default($nl, 'config_calving_strainrate_scaling', 'val'=>"5.0"); |
There was a problem hiding this comment.
Note that this option won't be doing anything if config_apply_facemelt_strainrate_enhancement=.false. and it looks like that is the current default.
There was a problem hiding this comment.
So that setting that to .true. also needs to be included in this logic block then?
There was a problem hiding this comment.
Yes, it needs to be set to .true. for the enhancement to be active. Good catch, @matthewhoffman.
| add_default($nl, 'config_calving_strainrate_scaling', 'val'=>"5.0"); | ||
| add_default($nl, 'config_crevasse_water_depth', 'val'=>"25.0"); |
There was a problem hiding this comment.
These two options (config_calving_strainrate_scaling, config_crevasse_water_depth) have default values applied further down (line 533 in modified file), so I would guess whatever is set here gets clobbered below.
Thinking about it more, because we are not using crevasse_depth calving for AIS grids at the moment, it would be simpler to just make the value you have here the default (i.e., in namelist_defaults_mali.xml) and remove their conditional assignment here. If we later on want to use crevasse_depth calving with different parameter values for different meshes, we can implement the conditional logic then.
| add_default($nl, 'config_calving_velocity_const'); | ||
| add_default($nl, 'config_data_calving'); | ||
| add_default($nl, 'config_calving_timescale'); | ||
| add_default($nl, 'config_restore_calving_front'); |
There was a problem hiding this comment.
@stephenprice , what are you using or this option? I'm thinking we probably want this disabled if we are using a physics-based calving law.
There was a problem hiding this comment.
In my current simulations, I have not changed these from their defaults.
|
@matthewhoffman and @trhille -- Please take another look and see if these reflect the changes we discussed. |
matthewhoffman
left a comment
matthewhoffman
left a comment
There was a problem hiding this comment.
@stephenprice , yes, this iteration matches our discussion. Looks good.
trhille
left a comment
trhille
left a comment
There was a problem hiding this comment.
Thanks @stephenprice, I agree this matches what we discussed.
4 participants
For MALI meshes that are used in prognostic, E3SM simulations with an active Greenland ice sheet, set the default calving parameters to be different than the standard default values used. This was tested via builds with the following three meshes and confirmed working:
mpas.gis4to40km,mpas.gis1to10kmR2, andmpas.gis1to10km. For the first two, the desired default values show up in themali_infile after a build. For the last one, the desired default values show up in themali_infile after a build.