EAMxx: elevated emissions reader#8385
Open
odiazib wants to merge 3 commits into
Open
Conversation
odiazib
added
BFB
odiazib
force-pushed
the
odiazib/eamxx/elevated_emissions_reader
branch
from
91abe10 to
10c364e
Compare
bartgol
approved these changes
May 12, 2026
Contributor
bartgol
left a comment
bartgol
left a comment
There was a problem hiding this comment.
Some mam4xx folks should also review this.
jeff-cohere
approved these changes
May 13, 2026
Contributor
Author
|
@jeff-cohere can we please merge it to next? |
Contributor
|
This is BFB, right? Just a reorganization of interpolation logic? |
Contributor
Author
Yes, It is BFB |
jeff-cohere
added a commit
that referenced
this pull request
May 13, 2026
…8385) Creates a separate vertical remapper for elevated emissions that is not derived from EAMxx's VerticalRemapper class, since the remapping operation is different. closes MAM4xx issue 553 [BFB]
Contributor
|
Merged to |
Contributor
|
@odiazib , should we wait for Aurora to report on the |
Contributor
Author
Hi @jeff-cohere, Yes, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a separate custom vertical remapper for vertical or elevated emissions: previously, we had three options in the MAM4xx remapper, VerticalRemapperMAM4, and two of them used pressure for interpolation. In the case of vertical emissions, altitude is used for interpolation. Therefore, to make the code easier to maintain, I created a new remapper.
Closes issue: eagles-project/mam4xx#553