Adding support for kokkos-tools#436
Draft
jeff-cohere wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
I guess now we have another reason to move to C++20: |
bartgol
requested changes
Apr 29, 2026
Contributor
bartgol
left a comment
bartgol
left a comment
There was a problem hiding this comment.
My biggest concern is linking the test session tgt to the catchmain tgt. I think we should avoid that. The other comment may be more debatable..
bartgol
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
At the 2026 ALCF hackathon, I've been using kokkos-tools (specifically the simple kernel timer) to understand performance bottlenecks in mam4xx. Kokkos-tools is easy to build and takes advantage of Kokkos instrumentation already compiled into an application, but it's a bit inconvenient to use because you have to set an environment variable to use it.
This PR introduces kokkos-tools as an optional feature for EKAT, and sets the environment variable appropriately in its bundled test session and catch2 main.
Testing
This is a build-system-only change--no new code features are added. I'm testing this in its feature branch at the hackathon. When I've verified that it works to my satisfaction, I'll mark this PR as ready for review.
Addenda
Apparently, kokkos-tools needs C++20, so this PR depends on #400.