Use SOURCES keyword for source files in EkatCreateUnitTestExec

[bartgol]

Motivation

The cmake function EkatCreateUnitTestExec uses a named argument for the source files list. However, I find this a bit error prone compared to the more modern cmake way (based on cmake_parse_arguments). In particular, it forces to use quotes to list all source files, and lists are one of the more tricky things in cmake: if you forget to quote, or use a var that expands to 2+ elements, the named argument would only bind to the 1st element, and the rest of the list will be parsed by cmake_parse_arguments. Moreover, keywords are much more self-documenting:

EkatCreateUnitTestExec (my_test
 "a.cpp;b.cpp;c.cpp"
)
EkatCreateUnitTestExec (my_test
  SOURCES a.cpp b.cpp c.cpp
)

To make sure this wasn't just my preference, I googled (and asked our bot friends), and it seems that keywords are in fact preferred over positional args, for readability and maintainability reasons. Let me know if you guys disagree.

E3SM Stakeholder Feedback

This will require to adapt the eamxx wrapper when we update ekat in e3sm.

[Copilot]

Pull request overview

This PR modernizes EKAT’s CMake unit-test helpers by switching source-file
specification from a positional argument to an explicit SOURCES keyword, making
call sites less error-prone and more self-documenting.

Changes:

• Update EkatCreateUnitTestExec / EkatCreateUnitTest to accept source files
  via the SOURCES multi-value keyword.
• Migrate existing test CMakeLists.txt call sites to the new SOURCES form.
• Minor refactor in tests/algorithm to create the tridiag_invalid_flags test
  directly from the selected precision executable.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
cmake/EkatCreateUnitTest.cmake	Introduces SOURCES keyword parsing and updates unit test creation flow.
cmake/EkatCreateUnitTestWithAsserts.cmake	Updates wrapper calls to pass sources via SOURCES.
tests/algorithm/CMakeLists.txt	Migrates to SOURCES keyword; refactors invalid-flags test creation.
tests/core/CMakeLists.txt	Migrates unit-test calls (and EkatCreateUnitTestExec) to SOURCES.
tests/expression/CMakeLists.txt	Migrates unit-test call to SOURCES.
tests/kokkos/CMakeLists.txt	Migrates unit-test calls to SOURCES.
tests/logging/CMakeLists.txt	Migrates unit-test calls to SOURCES.
tests/pack/CMakeLists.txt	Migrates unit-test calls to SOURCES.
tests/parser/CMakeLists.txt	Migrates unit-test call to SOURCES.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.