Use an alias for Kokkos' default view memory trait#442
Merged
Conversation
tcclevenger
commented
May 11, 2026
| using HostDevice = Kokkos::Device<Kokkos::DefaultHostExecutionSpace, Kokkos::DefaultHostExecutionSpace::memory_space>; | ||
|
|
||
| // Alias for Kokkos' default memory trait for views (managed memory, no special properties) | ||
| using ManagedMemoryTrait = Kokkos::MemoryTraits<0>; |
Contributor
Author
There was a problem hiding this comment.
@bartgol I didn't add this to KokkosTypes since it isn't device dependent. Also, I added "Trait" since I felt "MemoryManaged" wasn't very descriptive. I also considered KokkosManagedMemoryTrait or even KokkosDefaultMemoryTrait. Not sure if you have opinions on these.
Contributor
There was a problem hiding this comment.
I think this is fine. I hope this won't get used much anyways in ekat and customers (in favor of KokkosTypes' typedefs), so this is fine.
Does kokkos still have the unmanaged trait typedef in 5.x?
Contributor
Author
There was a problem hiding this comment.
Yes, Unmanaged still exists
bartgol
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an alias for Kokkos' default memory trait (managed memory, no other specializations) since Kokkos deprecated
using MemoryManaged = MemoryTraits<0>.