Change Brunt-Vaisala frequency vertical dimension and fill boundary values#404
Open
mwarusz wants to merge 1 commit into
Open
Change Brunt-Vaisala frequency vertical dimension and fill boundary values#404mwarusz wants to merge 1 commit into
mwarusz wants to merge 1 commit into
Conversation
a2fe5f0 to
0597323
Compare
Member
Author
TestingCTest unit tests
Polaris
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by the discussion in #394, this PR changes the Brunt-Vaisala frequency vertical extent to
NVertLayersP1, since it is a field that is located on interfaces. However, instead of filling the top and bottom interfaces with zeros or fill value, this PR sets these boundary values to values from the closest interior interface. This can be seen as equivalent to using one-sided differencing to calculate the boundary value, and is what is used in MPAS-O when the surface value of Brunt-Vaisala frequency is needed by the submesoscale eddy parametrization.Checklist
Testingwith the following:have been run on and indicate that are all passing.
has passed, using the Polaris
e3sm_submodules/Omegabaseline-pfor both the baseline (Polarise3sm_submodules/Omega) and the PR build