MPI fix to UOST file read - speed up#8
Merged
Conversation
sbrus89
approved these changes
May 1, 2026
Collaborator
sbrus89
left a comment
There was a problem hiding this comment.
Passes e3sm_wav_developerwith baseline comparison (and with significant speedup). Thanks for the great work @erinethomas!
Collaborator
|
@erinethomas, this is all set for a submodule update PR in E3SM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a MPI fix to WW3 that speeds up the reading of the unresolved obstacle ascii files. This massively speeds up the WW3 initialization speed. This PR addresses the long standing issue posted here:E3SM-Project/E3SM#6670
WW3 currently reads the ASCII files for unresolved obstacles on every processor. This PR puts in a MPI broadcast to reduce the number of processors trying to read the same file at once.
several tests were run to quantify initialization speed up as follows.
Overall, the initialization speed up is an order of magnitude, with negligible impact to the run time: