Fix unresolved path variables during ingestion #182
Merged
tomvothecoder merged 3 commits intoMay 12, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58486e79a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
DOUT_S_ROOTinenv_run*.xmlcontains unresolved shell variables ($CIME_OUTPUT_ROOT,$CASE), the simulation detail page displays raw variable names instead of actual paths.This PR adds a post-parse substitution step in the ingestion pipeline that resolves these variables using values extracted from
env_build*.xml(CIME_OUTPUT_ROOT) andenv_case*.xml(CASE).Changes:
Extract
CIME_OUTPUT_ROOTfromparse_env_build()Add
_substitute_path_variables()helper incase_docs.pyto replace$VARand${VAR}formsWire substitution into
_parse_all_files()forarchive_pathandoutput_pathAdd unit and integration tests
Closes [Bug]: Simulation detail page sometimes renders archive path variables unsubstituted #181
Checklist
Deployment Notes (if any)
No migration or deployment changes needed. Already-ingested simulations with unresolved paths are not retroactively fixed — a re-ingestion would be needed for those.