Skip to content

Make original plots always use multi-plot layout#17

Closed
chengzhuzhang wants to merge 1 commit into
mainfrom
feature/original-plots-multi-layout
Closed

Make original plots always use multi-plot layout#17
chengzhuzhang wants to merge 1 commit into
mainfrom
feature/original-plots-multi-layout

Conversation

@chengzhuzhang
Copy link
Copy Markdown
Collaborator

  • Add original_plots_multi flag to Parameters class
  • Modify make_plot_pdfs to use multi-plot layout for original plots
  • Change coupled_global to exclude original plots from interactive viewer
  • Add special handling for original plots in index page

Now when make_viewer=True:

  • Regular component plots use interactive viewer
  • Original plots are always displayed as multi-plot PDFs
  • Index page includes links to both interactive viewers and PDF files

🤖 Generated with Claude Code

Summary

Objectives:

  • Objective 1
  • Objective 2
  • ...
  • Objective n

Issue resolution:

  • Closes #<ISSUE_NUMBER_HERE>

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

Big Change

  • To merge, I will use "Create a merge commit". That is, this change is large enough to require multiple units of work (i.e., it should be multiple commits).

1. Does this do what we want it to do?

Required:

  • Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete.
  • Testing: I have considered likely and/or severe edge cases and have included them in testing.

2. Are the implementation details accurate & efficient?

Required:

  • Logic: I have visually inspected the entire pull request myself.
  • Logic: I have left GitHub comments highlighting important pieces of code logic. I have had these code blocks reviewed by at least one other team member.

If applicable:

  • Dependencies: This pull request introduces a new dependency. I have discussed this requirement with at least one other team member. The dependency is noted in zppy-interfaces/conda, not just an import statement.

3. Is this well documented?

Required:

  • Documentation: by looking at the docs, a new user could easily understand the functionality introduced by this pull request.

4. Is this code clean?

Required:

  • Readability: The code is as simple as possible and well-commented, such that a new team member could understand what's happening.
  • Pre-commit checks: All the pre-commits checks have passed.

If applicable:

  • Software architecture: I have discussed relevant trade-offs in design decisions with at least one other team member. It is unlikely that this pull request will increase tech debt.

- Add original_plots_multi flag to Parameters class
- Modify make_plot_pdfs to use multi-plot layout for original plots
- Change coupled_global to exclude original plots from interactive viewer
- Add special handling for original plots in index page

Now when make_viewer=True:
- Regular component plots use interactive viewer
- Original plots are always displayed as multi-plot PDFs
- Index page includes links to both interactive viewers and PDF files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@forsyth2
Copy link
Copy Markdown
Collaborator

This commit is included in #16, so closing this PR.

@forsyth2 forsyth2 closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants