Remove duplicate logs#29
Merged
Merged
Conversation
Collaborator
Author
|
Unfortunately, running into #30, which is making it difficult to test if logs are actually working. |
Collaborator
Author
|
After addressing #30, I'm actually able to run this, and it looks like the logs do indeed only print once now! Run detailsgit checkout issue-10-logger
pre-commit run --all-files
conda clean --all --y
conda env create -f conda/dev.yml -n zi-issue-10-logger-20250710
conda activate zi-issue-10-logger-20250710
python -m pip install .
cd ~/ez/zppy
git checkout test-zi-logging
conda clean --all --y
conda env create -f conda/dev.yml -n zppy-zi-logger-20250710
conda activate zppy-zi-logger-20250710
# Edit tests/integration/utils.py
# UNIQUE_ID = "test-zi-logger-20250710"
# "global_time_series_environment_commands": "source /gpfs/fs1/home/ac.forsyth2/miniforge3/etc/profile.d/conda.sh; conda activate zi-issue-10-logger-20250710",
python tests/integration/utils.py
python -m pip install .
zppy -c tests/integration/generated/test_weekly_comprehensive_v3_chrysalis.cfg
# WAIT
cd /lcrc/group/e3sm/ac.forsyth2/zppy_weekly_comprehensive_v3_output/test-zi-logger-20250710/v3.LR.historical_0051/post/scripts && grep -v "OK" *status
# No error!
emacs global_time_series_1985-1995.o793583
# Looks like logger lines are now only printing once! |
Collaborator
Author
|
@tomvothecoder @chengzhuzhang Did either of you want to review this, or can I go ahead and merge? |
tomvothecoder
approved these changes
Jul 15, 2025
tomvothecoder
left a comment
There was a problem hiding this comment.
I'm glad only single log messages are now printed. This PR looks good to me.
This was referenced Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow example of E3SM-Project/e3sm_diags#955 to remove duplicate logger lines. This will be helpful for debugging logs in E3SM-Project/zppy#719 & #25.
Objectives:
Issue resolution:
Select one: This pull request is...
Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other.
Small Change