Improve image checker#699
Merged
Merged
Conversation
667eec9 to
0828fb4
Compare
0828fb4 to
4e3d5b3
Compare
Collaborator
Author
|
Using the code as of 4e3d5b3, this is the Summary of test resultsDiff subdir is where to find the lists of missing/mismatched images, the image diff grid, and the individual diffs.
|
Collaborator
Author
|
To convert to web pages: |
Collaborator
Author
|
These numbers actually do match the numbers in #634 (comment), so it appears to be working as intended. Since this PR only touches testing code (i.e., not user-facing code), and I am the primary user for these changes, no further review is necessary. I do hope to make several more testing updates (e.g., #685, #520/#698), but this PR is an important step forward in automating the testing process. |
This was referenced Apr 2, 2025
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is specifically to speed up analysis of existing image checker tests. It will likely replace #685 and #695 completely, but ultimately #520/#698 will be needed to 1) automate the pre-test runs of
zppyitself and 2) test many morecfgfiles than the existing ones tested by the image checker.Objectives:
UNIQUE_IDs other than the one on the current branch.Issue resolution:
Select one: This pull request is...
Small Change