Conversation
This merge removes `LD_LIBRARY_PATH` and `LD_PRELOAD` from the environment before making `hsi` calls so conda or pixi environments don't cause conflicts (e.g. with `libncurses`).
Collaborator
Author
|
We don't actually merge this PR, because we want to test this RC in the next Unified RC before actually merging it to include officially. We just need this PR's branch. |
Collaborator
Author
|
Note: we actually can't use this exact branch name because it collides with the tag name. |
Contributor
|
Yes, please delete the branch before you push the tag. |
Collaborator
Author
|
Release process notes:
Step 1: setup/testingSkipping because we did partial testing on #440 and furthermore, we need to actually test that PR in the Unified environment to know if it worked. Step 2: Bump versionsStep 2a: ConfluenceAlready updated, when we made Step 2b: zstash repocd ~/ez/zstash
git status
# On branch isolate-hsi-calls
# nothing to commit, working tree clean
# IMPORTANT: Base off of #440's branch
git fetch xylar isolate-hsi-calls
git checkout -b v1.6.0rc2 xylar/isolate-hsi-calls
tbump 1.6.0rc2 --no-tag
git diff HEAD^ HEAD | cat
# Yes, these match up with changes in https://github.com/E3SM-Project/zstash/pull/438
git push upstream v1.6.0rc2
# Created https://github.com/E3SM-Project/zstash/pull/441
# But we don't actually need it.
# We just need its branch v1.6.0rc2
git tag v1.6.0rc2
git push upstream v1.6.0rc2
# The branch has a name that collides with the tag!
# (In the usual procedure, we checkout a reset main branch and delete this branch)
# Rename the branch here
git branch -m update-to-1.6.0rc2
# And delete the `v1.6.0rc2` branch on GitHub too!
# https://github.com/E3SM-Project/zstash/branches
# Let's try again. The tag was successful, so we just need to push to upstream
git push upstream v1.6.0rc2
# Successful this time
Step 2c: zstash-feedstock repocd /global/homes/f/forsyth/zstash-feedstock
curl -sL https://github.com/E3SM-Project/zstash/archive/v1.6.0rc2.tar.gz | openssl sha256
# SHA2-256(stdin)= b78dea5fc2d771cec2441de21c0e8d5137d2f4689633c7795ad201f80bfc9a31
git status # Check for uncommitted changes
git fetch upstream dev
git checkout -b v1.6.0rc2 upstream/dev
emacs recipe/meta.yaml
# In `recipe/meta.yaml`, update the version and sha256 (and the build number if needed):
# {% set version = "1.6.0rc2" %}
# sha256: ... # The sha256 from the previous step
# number: 0 # build >>> number should always be 0
# From https://github.com/conda-forge/zppy-interfaces-feedstock/pull/5#pullrequestreview-3351366258:
# Please always check the diff between the tag you're making a package for and the previous one. Please look for changes e.g. in dev.yml
# Review:
# https://github.com/E3SM-Project/zstash/compare/v1.6.0rc1...v1.6.0rc2
# So, it looks like there's nothing to change then.
git add -A
git commit -m "v1.6.0rc2"
git push forsyth2 v1.6.0rc2Created conda-forge/zstash-feedstock#26 (accidentally set merge branch to be |
Contributor
|
Looks good. |
This was referenced Apr 15, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump to v1.6.0rc2