Migrate run() pipeline logging from print() to Python logging module#160
Open
krrishrastogi05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Migrate run() pipeline logging from print() to Python logging module#160krrishrastogi05 wants to merge 1 commit intoEAPD-DRB:mainfrom
krrishrastogi05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed: Replaced
print()statements in the solver execution pipeline (run()method in DataFileClass.py) with Python'sloggingmodule.Why: The current
print()calls work fine for basic debugging, but they don't give us log levels, timestamps, or any way to capture output programmatically. As we move forward, we'll need to track multi-step execution and potentially stream progress to the UI. Python logging gives us all that while keeping the same console output by default.Related issues
Validation
How to test:
To see the structured logging with timestamps, add this to app.py:
Then output becomes:
Documentation
No doc changes needed — this is a drop-in replacement that doesn't change any external behavior.
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)