Skip to content

[v5.5] Fix result metadata and shadow-price rendering (align with upstream Variables.json)#406

Closed
MahadevBalla wants to merge 1 commit intoEAPD-DRB:mainfrom
MahadevBalla:feature/392-v55-result-metadata
Closed

[v5.5] Fix result metadata and shadow-price rendering (align with upstream Variables.json)#406
MahadevBalla wants to merge 1 commit intoEAPD-DRB:mainfrom
MahadevBalla:feature/392-v55-result-metadata

Conversation

@MahadevBalla
Copy link
Copy Markdown
Contributor

@MahadevBalla MahadevBalla commented Apr 2, 2026

Linked issue

Existing related work reviewed

Overlap assessment

Why this PR should proceed

Summary

  • What changed:
    • Adopted and applied upstream Variables.json as source of truth across Pivot rendering
    • Fixed unit rendering using unitRule instead of hardcoded n/a
    • Added support for RYCn (constraint group)
    • Fixed Pivot handling and field rendering for RYC, RYE, and RYCn groups
    • Synced updateView logic with updateParam
    • Cleared pivot data when no results exist (prevents stale UI)
  • Why:
    • Previous implementation assumed Tech-based groups
    • New v5.5 groups use different dimensions (Comm, Emi, Con)
    • Pivot needed to respect upstream grouping and unit rules

Validation

  • Tests added/updated (not applicable; UI layer, no existing test coverage)
  • Validation steps documented
  • Evidence attached (logs/screenshots/output as relevant)

Manual validation:

  • Shadow price - Energy Balance (RYC)

    • commodity-based pivoting works
    • units render from metadata
  • Shadow price - Emissions Limit (RYE)

    • emission-based pivoting works
    • units render from metadata
  • Shadow price - UDC Inequality (RYCn)

    • constraint-based pivoting works
    • units render correctly
  • Shadow price - UDC Equality (RYCn)

    • empty-state clears stale pivot/grid/chart content
  • Number Of New Technology Units

    • number-based unit handling works
  • Rechecked representative existing result paths:

    • New Capacity
    • New Storage Capacity
    • Input To New Capacity
    • Rate Of Activity

RYC – Shadow price - Energy Balance

image

RYCn – Shadow price - UDC Inequality

image

RYCn – Shadow price - UDC Equality (empty state)

image

RYT – Number Of New Technology Units

image

Documentation

  • Docs updated in this PR (not applicable)
  • Any setup/workflow changes reflected in repo docs

Scope check

  • No unrelated refactors
  • Implemented from a feature branch
  • Change is deliverable without upstream OSeMOSYS/MUIO dependency
  • Base repo/branch is EAPD-DRB/MUIOGO:main (not upstream)

Exception rationale

@parthdagia05
Copy link
Copy Markdown

405

@MahadevBalla
Copy link
Copy Markdown
Contributor Author

Adding context wrt #405, this PR includes the metadata updates but also wires them into the Pivot layer (unitRule usage, group handling, empty state, etc.), so the changes are actually reflected in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Fix result metadata and shadow-price rendering from MUIO v5.5

2 participants