[v5.5] Fix result metadata and shadow-price rendering (align with upstream Variables.json)#406
Closed
MahadevBalla wants to merge 1 commit intoEAPD-DRB:mainfrom
Closed
Conversation
Contributor
Author
|
Adding context wrt #405, this PR includes the metadata updates but also wires them into the Pivot layer (unitRule usage, group handling, empty state, etc.), so the changes are actually reflected in the UI. |
4c68970 to
49c72c9
Compare
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
Overlap assessment
Variables.jsonand registers result groups at the metadata levelunitRuleis applied in Pivot for result groups that define units via metadata (while keeping upstreamObjective Valuebehavior asn/a)RYC,RYE,RYCnupdateParamandupdateViewWhy this PR should proceed
Summary
Variables.jsonas source of truth across Pivot renderingunitRuleinstead of hardcodedn/aRYCn(constraint group)RYC,RYE, andRYCngroupsupdateViewlogic withupdateParamValidation
Manual validation:
Shadow price - Energy Balance(RYC)Shadow price - Emissions Limit(RYE)Shadow price - UDC Inequality(RYCn)Shadow price - UDC Equality(RYCn)Number Of New Technology Unitsnumber-based unit handling worksRechecked representative existing result paths:
New CapacityNew Storage CapacityInput To New CapacityRate Of ActivityRYC – Shadow price - Energy Balance
RYCn – Shadow price - UDC Inequality
RYCn – Shadow price - UDC Equality (empty state)
RYT – Number Of New Technology Units
Documentation
Scope check
OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:main(not upstream)Exception rationale