chore: remove leftover debug console.log statements from WebAPP/App/ (fixes #436)#437
Open
parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
chore: remove leftover debug console.log statements from WebAPP/App/ (fixes #436)#437parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
parthdagia05 wants to merge 1 commit intoEAPD-DRB:mainfrom
Conversation
Removes 25 active console.log debug calls across 20 files in WebAPP/App/Controller/ and WebAPP/App/Model/. These fired during normal user actions (page loads, cell edits, case selection) and in some cases dumped entire model objects to the browser console. Scope notes: - Preserves console.error (intentional error logging) and commented-out // console.log(...) lines (out of scope). - Skips WebAPP/Classes/*.js since those are upstream-overlap surface per docs/UPSTREAM_SYNC.md and would risk merge conflicts at the next MUIO sync. Follows the cleanup precedent from EAPD-DRB#422, which removed similar debug logs from Pivot.js, DataModelResult.Class.js, and Const.Class.js during the v5.5 sync. Fixes EAPD-DRB#436
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Existing related work reviewed
console.logs during v5.5 sync); issues [Task] Remove dead commented-out code and deprecated API route #221, [Task] Remove obsolete CSV generator backup methods (~600 lines dead code) #332, [Tracking] Minor UI Polish Follow-ups #425, PR fix: correct spelling errors in UI text #374 (different scopes - Python dead code / UI polish).Overlap assessment
WebAPP/App/were untouched and no open issue/PR covers them.Why this PR should proceed
WebAPP/Classes/*perdocs/UPSTREAM_SYNC.md).Summary
console.logcalls across 20 files inWebAPP/App/Controller/andWebAPP/App/Model/.Validation
grep -rn '^\s*console\.log' WebAPP/App/returns no matches. All 20 files passnode --input-type=module --check.git diff --checkclean. Branched off latestupstream/main(5f8f89a).Documentation
Scope check
chore/remove-debug-console-logs)OSeMOSYS/MUIOdependencyEAPD-DRB/MUIOGO:mainException rationale
N/A - uses linked issue #436.