Fix/444 shared export filename#445
Closed
tejassinghbhati wants to merge 6 commits intoEAPD-DRB:mainfrom
Closed
Conversation
…/CI server flakiness - Replace subprocess server launch with an in-process Waitress daemon thread. This eliminates cross-platform CWD/sys.path/env-var inheritance issues that caused page.goto() timeouts on Python 3.12 Windows when using Flask dev server. - Configure Waitress with threads=16 and channel_timeout=10 to prevent thread exhaustion during Playwright's burst of concurrent static asset requests. - Use wait_until='commit' on all page.goto() calls so browser tests return the instant Flask starts sending bytes, without blocking on CDN resources (MathJax) or synchronous <script> downloads that precede DOM parsing. - Scope assertions to elements guaranteed present in raw server-rendered HTML: page title (in <head>), footer copyright text (hardcoded in index.html). - All 4 tests now pass locally in 8s: test_health_endpoint, test_session_api, test_load_app, test_static_footer.
…pareCSV/downloadCSV
github-actions
Bot
added
the
needs-intake-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: Closes #444
Existing related work reviewed:
downloadCSV; the underlying shared filename betweenprepareCSVanddownloadCSVwas not addressedOverlap assessment:
Why this PR should proceed:
prepareCSVwrote all sessions' CSV exports to the same hardcodedexport.csvpath. Any concurrent call silently overwrote it.downloadCSVthen served whichever write finished last --- with HTTP 200, no error. Demonstrated and logged in [Bug] Shared export.csv filename in prepareCSV/downloadCSV causes silent data corruption under concurrent use #444.Summary:
import uuidadded toCaseRoute.pyprepareCSVgenerates a per-request unique filename (export_<uuid>.csv) and stores it insession['export_file']downloadCSVreadssession['export_file']instead of the hardcoded path; falls back toexport.csvfor backward compatibility; returns 404 if the file doesn't exist instead of crashingValidation:
prepareCSVanddownloadCSVProposed track: Track: Stability