fix(#444): scope export CSV to session-unique filename in prepareCSV/downloadCSV#446
Open
tejassinghbhati wants to merge 1 commit intoEAPD-DRB:mainfrom
Open
Conversation
…pareCSV/downloadCSV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: Closes #444
Existing related work reviewed:
downloadCSV; the underlying shared filename betweenprepareCSVanddownloadCSVwas not addressedOverlap assessment:
Why this PR should proceed:
prepareCSVwrote all sessions' CSV exports to the same hardcodedexport.csvpath. Any concurrent call silently overwrote it.downloadCSVthen served whichever write finished last --- with HTTP 200, no error. Demonstrated and logged in [Bug] Shared export.csv filename in prepareCSV/downloadCSV causes silent data corruption under concurrent use #444.Summary:
import uuidadded toCaseRoute.pyprepareCSVgenerates a per-request unique filename (export_<uuid>.csv) and stores it insession['export_file']downloadCSVreadssession['export_file']instead of the hardcoded path; falls back toexport.csvfor backward compatibility; returns 404 if the file doesn't exist instead of crashingValidation:
prepareCSVanddownloadCSVProposed track: Track: Stability