Skip to content

fix: correct guard order in OsemosysClass.RYE() to prevent phantom Em… #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lil-aditya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct guard order in OsemosysClass.RYE() to prevent phantom Em… #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions API/Classes/Case/OsemosysClass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,9 +613,9 @@ def RYE(self, RYEdata):
RYE[param][sc] = {}
for o in array:
for year, val in o.items():
if year not in RYE[param][sc]:
RYE[param][sc][year] = {}
if (year != 'EmisId'):
if year not in RYE[param][sc]:
RYE[param][sc][year] = {}
RYE[param][sc][year][o['EmisId']] = val
Comment on lines 616 to 619
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description references running python scripts/reproduce_rye_bug.py, but that file does not exist in the repository/PR branch. Either add the script to scripts/ or update the validation instructions to point at an existing reproduction path so reviewers can verify the fix.

Copilot uses AI. Check for mistakes.
return RYE

Expand Down
Loading