EVA-4081: Use previous mappings as source of truth and Zooma/OxO only for curation#497
Merged
apriltuesday merged 12 commits intoEBIvariation:masterfrom Mar 12, 2026
Merged
Conversation
tcezard
reviewed
Mar 5, 2026
Member
tcezard
left a comment
tcezard
left a comment
There was a problem hiding this comment.
It looks good just left one question on something I'm not sure about.
tcezard
approved these changes
Mar 10, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main functional changes are:
trait_processing.pyandtrait.py- new logic for determining when traits are finishedoutput.pyandcreate_table_for_manual_curation.py- consolidated logic for generating the final candidates for curation in the formerI also updated the files that the E2E tests were based on, particularly the mapping file as a lot of the mappings were obsolete which wasn't giving a realistic representation of what the curation would look like. The spreadsheet I used for the test can be viewed here, the full dataset is still pending.