Skip to content

add 3hr winds at 10m when re-cmorising#878

Merged
treerink merged 1 commit intomasterfrom
add_3hr_uas_and_vas
Apr 1, 2026
Merged

add 3hr winds at 10m when re-cmorising#878
treerink merged 1 commit intomasterfrom
add_3hr_uas_and_vas

Conversation

@klauswyser
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@treerink treerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree the lines for the 3hr => 3hrPt had to be added (that was what came to my mind this morning during the meeting).

The upper modification, should be not necessary with the provided config file (same values). Though on this part later we need to make the final adjustments after the registration is done. Or do I overlook something?

So actually I suggest to leave out these changes concerning the institution_id & source_id.

Actually my idea is to take the path of the input CMIP6 cmorised data in the submit script also from the config file (so only one place needs to be adjusted) and then the source_id in the config file will become the CMIP7 source_id.

@klauswyser
Copy link
Copy Markdown
Collaborator Author

Well, it didn't work for me with the config file. The problem is that e.g. source_id is used to first find the CMIP6 file, and then translate it to CMIP7 with the same source_id. This doesn't work beacsue our files contain EC-Earth3-ESM-1 in their name so source_id should us this, but it then cannot write CMIP7 files because EC-Earth3-ESM-1 isn't defined in the CMIP7 CV.

It may work for you because you possibly have added EC-Earth3-ESM-1 to your CMIP7 CV file but I don't have that.

@treerink
Copy link
Copy Markdown
Collaborator

Yes, that's achieved by running the script:
./add-ols-in-cmip7-cmor-table.s
which is in my case called by the submit script.
(The name of this script does not cover this aspect, but this is temporary).

@klauswyser
Copy link
Copy Markdown
Collaborator Author

Well, "ols" doesn't need to be fixed any longer...

And this script isn't included when running add_optimesm_vars, or did I miss anything?

@treerink
Copy link
Copy Markdown
Collaborator

Ok I removed the temporary ols fix after #879. And changed the name of the temporary add script to add-ECE3-ESM-1-1-to-cmip7-cmor-table.sh. For the recmorisation no call to the ./add-optimesm-variables.sh is necesarry. And that script does injections to the CMIP6 CMOR Tables (not the CMIP7 CMOR Tables).

@treerink treerink merged commit 49e0de5 into master Apr 1, 2026
1 check passed
@treerink treerink deleted the add_3hr_uas_and_vas branch April 1, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants