Open
Conversation
Shan1024
force-pushed
the
update-imports
branch
from
ff7a98e to
43328e0
Compare
Shan1024
commented
Nov 16, 2019
| string headerValue = request.getHeader(http:AUTH_HEADER); | ||
|
|
||
| if !(headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { | ||
| if (!headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { |
Author
There was a problem hiding this comment.
Note - This is swapped here because otherwise no point of wrapping the expression with parentheses.
Collaborator
There was a problem hiding this comment.
Shall we just remove the extra parentheses instead.
Suggested change
| if (!headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { | |
| if !headerValue.startsWith(auth:AUTH_SCHEME_BASIC) { |
There was a problem hiding this comment.
Shall we just remove the extra parentheses instead.
Why don't keep parentheses to maintain consistency of coding style?
MaryamZi
reviewed
Dec 14, 2019
| string headerValue = request.getHeader(http:AUTH_HEADER); | ||
|
|
||
| if !(headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { | ||
| if (!headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { |
Collaborator
There was a problem hiding this comment.
Shall we just remove the extra parentheses instead.
Suggested change
| if (!headerValue.startsWith(auth:AUTH_SCHEME_BASIC)) { | |
| if !headerValue.startsWith(auth:AUTH_SCHEME_BASIC) { |
|
|
||
| # Listener for results tabulation to deliver results to us. | ||
| listener http:Listener resultsListener = new (config:getAsInt("eclk.pub.port", 8181), { | ||
| listener http:Listener resultsListener = new(config:getAsInt("eclk.pub.port", 8181), { |
Collaborator
There was a problem hiding this comment.
The standard we follow is to leave a space to be consistent with
listener http:Listener resultsListener = new http:Listener(config:getAsInt("eclk.pub.port", 8181), {
Collaborator
|
@Shan1024 Shall we do the aforementioned suggestion to get the changes merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves formatting and reorders imports.