Conversation
ifosch
force-pushed
the
revamp-appu/migrate-appu
branch
from
7588e7b to
6f23ca4
Compare
ifosch
force-pushed
the
revamp-appu/migrate-appu
branch
5 times, most recently
from
d0c4a92 to
824f08f
Compare
added 3 commits
March 16, 2025 10:06
This command provides the features we have in the old appu's Python code: * Loads configuration for the episode * downloads the master audio specified in the episode configuration * normalizes the audio in the recording * downloads the intro file and the cover image * splits the intro file * concatenates the intro, the recording, and the outro all together * exports the track, with the corresponding ID3 tags, including the cover image * uploads the track to the destination for the edited recording This change also includes using `audioop-lts`, which is a `pydub`'s dependency in Python 3.13.
This adds `pytest` testing for the new `appu` subcommand, and the code provided. Those tests are also included in the `test` pipeline to test the subcommand within the CI pipeline. This uses a container to run the tests, so it also validates building the APPU 2's container. All the other steps in the CI pipeline, are selected to skip when requesting to pull from a branch with `revamp` in the name. Ideally, this should prevent issues between revamping changes and other possible changes coming in. The `PYTHONWARNINGS` environment variable in the Dockerfile is provided to prevent weird output caused by [an issue with `pydub` and regular expression support for Python 3.12](jiaaro/pydub#801).
ifosch
force-pushed
the
revamp-appu/migrate-appu
branch
from
824f08f to
9ef889c
Compare
ifosch
changed the title
Member
Author
|
@davidpoblador This PR, based on revamp branch, is, IMO, ready for merging. Happy to hear your feedback on this, or discussing any detail. |
|
This looks, good! I will review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an
appusubcommand to APPU 2, with the same features as oldappuprogram/container. This also introduces a first version for a container image for APPU 2.This proposal takes one first step to replace old
apputooling with a new one. In theory, this could replace the Edit and upload the audio file step in the publishing pipeline.Check out the commit messages for more information regarding:
Further work in this direction, pending discussions, could be:
epidatorfeedupdateruploader