Skip to content

Add SentenceTransformer to NLQ#26

Open
miguelmartin75 wants to merge 1 commit intomainfrom
sent_xformer
Open

Add SentenceTransformer to NLQ#26
miguelmartin75 wants to merge 1 commit intomainfrom
sent_xformer

Conversation

@miguelmartin75
Copy link
Copy Markdown
Collaborator

Caveat: since SentenceTransformer reduces the input features from [B, T] -> [B, 768], I don't pass the token embeddings to the shared feature_encoder

@satwikkottur
Copy link
Copy Markdown
Collaborator

satwikkottur commented Sep 16, 2022

Thanks @miguelmartin75 for this PR.

Two comments:

  1. Can we have choices for --predictor flag in options.py? Since we're adding addition predictors, would be nice to restrict that set.
  2. Between st and sentence_transformer (or even sent_transformer), I prefer the latter for readability. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants