api: move JwtAuthFilter ahead of Spring SAS validating filter#184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault OIDC sign-in 302s to
?error=invalid_request&error_description=OAuth 2.0 Parameter: principalbecauseJwtAuthFilterwas positioned too late in the auth-server chain.Spring SAS 7's
OAuth2AuthorizationCodeRequestValidatingFilter(registered beforeAbstractPreAuthenticatedProcessingFilter) snapshotsSecurityContextHolderinto a request attribute.OAuth2AuthorizationEndpointFilterlater reuses that snapshot.JwtAuthFilterwas added beforeUsernamePasswordAuthenticationFilter, which runs after the validating filter — so the snapshot was always anonymous even when the BSH_AUTH cookie was valid.Move it to after
SecurityContextHolderFilterso it runs first, like personal-stack-2 gets viaHttpSessionSecurityContextRepository. Also reverts theanonymousAuthorizeLoginRedirectworkaround from #183 — no longer needed once the snapshot is correct.