Show all users on the contribution manager#374
Merged
Conversation
The Contribution Manager's paid/unpaid lists only included users with an active membership, so non-members who had paid (or owed) a contribution were invisible to the board. The lists now contain every user returned by findUsers(), partitioned by whether the user has a contribution for the selected period. Membership state no longer gates visibility; the row already renders a Member/User chip to distinguish the two. Paid/unpaid are derived as computed lists from a selected-period contribution set, an undefined period clears the state, and stale period fetches are ignored.
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Contribution Manager's "Contribution paid" / "Contribution unpaid" lists only included users with an active membership. Non-members who had paid — or who owed — a contribution were invisible to the board, so payment status could not be reconciled for the full user base.
Change
Both lists now contain every user returned by
findUsers(), partitioned by whether the user has a contribution for the selected period. Membership state no longer gates visibility. The contribution row already renders a Member/User chip, so the two groups remain distinguishable.Supporting changes in
ContributionManager.vue:computedlists from a selected-period contribution set, replacing the membership-filteredwatch.findMemberships,MembershipResponse, themembershipsref,hasActiveMembership,getMemberships) is removed, along with the write-onlycontributionPeriodref.The Member Manager is unaffected.
Tests
ContributionManager.test.tscovers all users being split by the selected period (including a non-member and a contribution from a different period that must not count as paid), the no-period state, and contribution upsert/delete.Verified from
services/frontend:yarn typecheck,yarn lint, andyarn test:unit(312 tests) pass.