Skip to content

Bugfix for registry variables with dimensions that are themselves registry variables#462

Merged
peverwhee merged 6 commits into
ESCOMP:developmentfrom
peverwhee:dim-locnames
Apr 24, 2026
Merged

Bugfix for registry variables with dimensions that are themselves registry variables#462
peverwhee merged 6 commits into
ESCOMP:developmentfrom
peverwhee:dim-locnames

Conversation

@peverwhee
Copy link
Copy Markdown
Collaborator

@peverwhee peverwhee commented Jan 13, 2026

Tag name (required for release branches):
Originator(s): peverwhee, jimmielin

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Bugfix for dimensions that are defined in the registry and then used to allocate a different registry variable.

Describe any changes made to build system:

M    src/data/generate_registry_data.py
- use the local name for allocating dimensions defined in the registry (but use standard name for metadata)

Describe any changes made to the namelist: n/a

List any changes to the defaults for the input datasets (e.g. boundary datasets): n/a

List all files eliminated and why: n/a

List all files added and what they do:

A  test/unit/python/sample_files/physics_types_self_ref_dim.F90
A  test/unit/python/sample_files/physics_types_self_ref_dim.meta
A  test/unit/python/sample_files/reg_good_self_ref_dim.xml
- add new test that exercises dimension handling

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M   test/unit/python/test_registry.py
- add new test that exercises dimension handling

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: all b4b, except expected NLFAIL for multitape

derecho/gnu/aux_sima: all b4b, except expected FAIL for FADIAB

derecho/nvhpc/aux_sima: run through workflow - b4b

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@peverwhee peverwhee requested a review from nusbaume January 13, 2026 23:29
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

@nusbaume nusbaume requested a review from jimmielin January 14, 2026 13:41
Copy link
Copy Markdown
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

@peverwhee peverwhee temporarily deployed to CI-tests-on-CIRRUS April 23, 2026 20:09 — with GitHub Actions Inactive
@peverwhee peverwhee merged commit 56fed51 into ESCOMP:development Apr 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants