-
Notifications
You must be signed in to change notification settings - Fork 18
CCPPize prescribed_volcanic_aerosol (prescribed_volcaero); update tracer_data_test snapshot #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimmielin
wants to merge
10
commits into
ESCOMP:development
Choose a base branch
from
jimmielin:hplin/volcrad_aero_prescribe
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−12
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d4f3c84
Add VOLC_MMR, VOLC_RAD_GEOM registry entries for prescribed volcanic …
jimmielin 119f803
Update snapshot file for volcaero
jimmielin 60910c7
Closes #283 - fixes boltz, avogad units in meta.
jimmielin b57e821
Merge branch 'development' into hplin/volcrad_aero_prescribe
jimmielin 2659fae
Merge branch 'development' into hplin/volcrad_aero_prescribe
jimmielin eb45392
Merge branch 'development' into hplin/volcrad_aero_prescribe
jimmielin 9e8c5a8
Revert change to boltz units. @nusbaume wrote:
jimmielin 50f78ab
Merge branch 'development' into hplin/volcrad_aero_prescribe
jimmielin c392140
Update to use for inputs of prescribed
jimmielin ada1b7f
Fixup! Use curly braces DIN_LOC_ROOT to avoid double-quoting
jimmielin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking if it is okay that many of these aerosol fields are zero times
pbuf_sulf? It totally might be, I am just trying to understand the reasoning behind it. Thanks!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the question. Yes, it is intended! It is just to zero out these fields in the "before" snapshot, so that
ncdata_checkcan verify that the zeros in the model state indeed were populated by the tracer_data schemes.The reason I used
<something>=0.0*pbuf_sulfis because nco with<something>=0.0will set the 2-D array into a scalar, and thus losing the dimensions; so I just borrowed thepbuf_sulf*0.0to get a 2-D array of zeros to put into that variable. Hope this explains it!