Add support for accumulated history fields#487
Open
peverwhee wants to merge 21 commits into
Open
Conversation
… accumulated-fields
…-SIMA into accumulated-fields
jimmielin
reviewed
Apr 9, 2026
nusbaume
requested changes
Apr 29, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for bringing in the new history accumulation features (and fixing some bugs) @peverwhee! I have some questions and change requests, but if you run into problems with any of them then just let me know. Thanks again!
This was referenced May 14, 2026
… hist fields with different flags on same volume
nusbaume
requested changes
May 15, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for addressing my concerns @peverwhee! I had two remaining cleanup requests, but after that we should be good to go. Thanks again!
| @@ -1556,23 +1555,19 @@ subroutine config_write_field(this, field, split_file_index, restart, & | |||
| frank = size(field_shape) | |||
| if (frank == 1) then | |||
| if (trim(field_precision) == 'REAL32') then | |||
Collaborator
There was a problem hiding this comment.
Why have this REAL32 check here at all? It looks like the allocate statements are now exactly the same.
| call check_allocate(ierr, subname, 'field_data', file=__FILE__, line=__LINE__-1, errmsg=errmsg) | ||
| end if | ||
| else | ||
| if (trim(field_precision) == 'REAL32') then |
Collaborator
There was a problem hiding this comment.
Same question here, is this if-statement needed anymore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches): TBD
Originator(s): peverwhee
AI tools used (if applicable; please also add the "AI-generated code" label to the PR): n/a
What:
How:
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system:
Describe any changes made to the namelist: n/a
List any changes to the defaults for the input datasets (e.g. boundary datasets): n/a
List all files eliminated and why: n/a
List all files added and what they do: n/a
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima: run via github workflow
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: