sima0_13_005: Move nswbands, nlwbands to host namelist (needs atmos_phys update)#493
Merged
Merged
Conversation
jimmielin
added
the
code clean-up
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
GitHub Actions
Failure
peverwhee
reviewed
Apr 21, 2026
| Units: count | ||
| </desc> | ||
| <values> | ||
| <value>14</value><!-- rrtmgp --> |
Collaborator
There was a problem hiding this comment.
How likely is it that a user would change these? I'm wondering if it would make more sense to move these to the registry and initialize them to 14, 16?
Member
Author
There was a problem hiding this comment.
Thanks for the question! It was hardcoded in radconstants.F90 in CAM so I feel it's a radiation-scheme-dependent quantity. I don't feel strongly either way, but this particular set of values is specific to RRTMGP (RRTMG is 14, 14) and maybe it being here is more easily changeable when swapping radiation in the future, than in registry.xml?
Collaborator
There was a problem hiding this comment.
that's a good point! thanks for elaborating!
peverwhee
approved these changes
Apr 21, 2026
Member
Author
|
Thanks @peverwhee and @nusbaume! This will need the updated atmos_phys hash after ESCOMP/atmospheric_physics#384 is merged for the CIRRUS test to run successfully (otherwise it has duplicate metadata) |
jimmielin
changed the title
jimmielin
changed the title
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
GitHub Actions
Error
jimmielin
added a commit
to ESCOMP/atmospheric_physics
that referenced
this pull request
Apr 25, 2026
…tion species in initialize_constituents (#384) Tag name (The PR title should also include the tag name): Originator(s): @jimmielin Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): - Moves `nswbands`, `nlwbands` to host-side radiation_namelist (CAM-SIMA companion PR: ESCOMP/CAM-SIMA#493) - Closes #332 - Initializes number concentration species (NUMLIQ, NUMICE, ...) in the test `initialize_constituents.F90` scheme. List all namelist files that were added or changed: ``` M schemes/rrtmgp/rrtmgp_pre_namelist.xml - moved nlwbands, nswbands to host-side (no effect on CAM) ``` List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` M schemes/rrtmgp/rrtmgp_pre_namelist.xml - moved nlwbands, nswbands to host-side (no effect on CAM) M test/test_schemes/initialize_constituents.F90 - add number concentration species standard names and logic - set qmin for chemistry species based on mozart initialization in CAM. ``` List all automated tests that failed, as well as an explanation for why they weren't fixed: Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? If yes to the above question, describe how this code was validated with the new/modified features:
jimmielin
temporarily deployed
to
CI-tests-on-CIRRUS
GitHub Actions
Inactive
jimmielin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What:
How:
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Describe any changes made to build system:
Describe any changes made to the namelist: add nswbands, nlwbands to radiation_nl.
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: