ctsm5.4.042: Move $nl_flags->{'use_hillslope'} to a more effective spot#4046
Merged
slevis-lmwg merged 2 commits intoMay 23, 2026
Merged
Conversation
Contributor
Author
|
samsrabin
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In particular I'm moving the line
$nl_flags->{'use_hillslope'} = $nl->get_value('use_hillslope');from sub setup_logic_params_file in bld/CLMBuildNamelist.pm to sub setup_logic_hillslope (because it's called before setup_logic_params_file), in order to get the intended
hillslope_fsat_equals_zero(i.e., .true.) whenuse_hillslope = .true..Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Resolves #4030
If answers are expected to change, describe (delete this line otherwise):
Answers change for Hillslope cases only; the changes are greater than roundoff
Any user interface changes (namelist or namelist defaults changes)?
Now get the correct hillslope_fsat_equals_zero for
use_hillslope = .true.Testing planned or performed, if any:
Requirements before merge: