Update Rules, update schema file, add new test to validate XML #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ames OR nested section elements
…on names to the standard names character set
…precision, add "ddt" as options
This reverts commit 533ef71.
- include "of" as a potential modifier for "medium" - Add bullets on valid type entries, xml validation - Fix some formatting
…s' tables that have been moved to the XML
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
climbfuji
approved these changes
Jan 20, 2026
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for these bug fixes.
I made the new test to validate the XML file a required test for merging.
Can you please update the PR title to indicate that this PR does a little more than just adding a validation of the xml file?
mkavulich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the standard name rules to fix some errors, resolve some omissions, and remove information that was moved elsewhere. It also updates the
xsdschema file to properly account for the existing rules and XML format, and adds a test to validate the XML using the schema file.Rules updates
typeelements, and validating the XML with the schema fileinteger,real,logical,character,complex, orddtin_mediumorof_mediumas appropriateXML/schema updates
typeelement optional and update for new rules as aboveIssues
Resolves #136