Draft
Conversation
Cleaned up how the GCM interacts with some diagnostic attributes
The first time ecosys_driver_set_compute_now() is called, it loops through all of the MARBL diagnostics and sets compute_now = set_in_tavg_contents() for that diagnostic. Note that we use set_in_tavg_contents() instead of accumulate_now() because we need to set compute_now flags before the time manager is set up, and accumulate_now() returns False for all diagnostics at that stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Use a newer version of MARBL; take advantage of some performance improvements.
The big change is that MARBL will only compute diagnostic values for fields the driver has requested, rather than computing values that the driver then ignores.
Testing:
Test case/suite: will run
aux_pop_MARBLwhen done with the MARBL changesTest status: this should be bit-for-bit
User interface (namelist or namelist defaults) changes? N/A