-
Notifications
You must be signed in to change notification settings - Fork 33
Complete CCPPization of CAM5 UW PBL scheme (diag_TKE) #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimmielin
wants to merge
25
commits into
ESCOMP:main
Choose a base branch
from
jimmielin:hplin/diag_tke_rebase_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
86dd6e9
Initial push of UW PBL
jimmielin a972d91
Update interfaces to run phase
jimmielin a3a6794
Refactor HB: move kinematic fluxes and obklen to common vdiff interst…
jimmielin a544023
Draft metadata
jimmielin 8e83bb0
Remove unused metadata that was removed
jimmielin 3e6fb40
Keep removing moved metadata
jimmielin 1f935fc
Keep removing moved metadata (2)
jimmielin 633b8a6
Initial fixes for b4b in SIMA -- up to constituent diffusion
jimmielin 06fdad4
Fix for #332
jimmielin 8de2a05
Handle dropmixnuc; batch of fixes for constituent vertical diffusion …
jimmielin 92c64a8
Change cflx from coupler to from interstitial
jimmielin 0a75ad2
Do not mutate const_array; mutate q1 in vdiff ndropmixed alternate
jimmielin ca7f025
Sketch out UW PBL diagnostics; REARRANGE HB tautotx/tautoty and chang…
jimmielin 7896907
Fix turbtype_real dimension to pverp
jimmielin c47066c
Remove extraneous comments (as they are documented in the actual scheme)
jimmielin f7ca8e7
Fix qrl unit - should be adj by pressure thickness
jimmielin ea0f256
Merge branch 'main' into hplin/diag_tke_rebase_main
jimmielin 7b38644
Address review comments.
jimmielin 466253f
Update schemes/bretherton_park/bretherton_park_diff.meta
jimmielin f70b041
Fix qrl output unit
jimmielin 04d7c80
Address review comments
jimmielin a82989a
Merge branch 'hplin/diag_tke_rebase_main' of github.com:jimmielin/atm…
jimmielin 7742067
Fix namelist comment
jimmielin 401c2ba
Merge branch 'main' into hplin/diag_tke_rebase_main
jimmielin a73195d
Address second reviewer comments
jimmielin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
160 changes: 160 additions & 0 deletions
160
schemes/bretherton_park/bretherton_park_diff_namelist.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| <?xml version="1.0"?> | ||
|
|
||
| <?xml-stylesheet type="text/xsl"?> | ||
|
|
||
| <entry_id_pg version="2.0"> | ||
|
|
||
| <!-- Each namelist variable is defined in an <entry> element. The | ||
| content of the element is the documentation of how the variable is | ||
| used. Other aspects of the variable's definition are expressed as | ||
| attributes of the <entry> element. Note that it is an XML requirement | ||
| that the attribute values are enclosed in quotes. The attributes are: | ||
|
|
||
| id | ||
| The variable's name. *** N.B. *** The name must be lower case. | ||
| The module convert all namelist variable names to lower case | ||
| since Fortran is case insensitive. | ||
|
|
||
| type | ||
| An abbreviation of the fortran declaration for the variable. | ||
| Valid declarations are: | ||
|
|
||
| char*n | ||
|
nusbaume marked this conversation as resolved.
|
||
| integer | ||
| logical | ||
| real | ||
|
|
||
| Any of these types may be followed by a comma separated list of | ||
| integers enclosed in parenthesis to indicate an array. | ||
|
|
||
| The current namelist validation code only distinquishes between | ||
| string and non-string types. | ||
|
|
||
| input_pathname | ||
| Only include this attribute to indicate that the variable | ||
| contains the pathname of an input dataset that resides in the | ||
| CESM inputdata directory tree. Note that the variables | ||
| containing the names of restart files that are used in branch | ||
| runs don't reside in the inputdata tree and should not be given | ||
| this attribute. | ||
|
|
||
| The recognized values are "abs" to indicate that an absolute | ||
| pathname is required, or "rel:var_name" to indicate that the | ||
| pathname is relative and that the namelist variable "var_name" | ||
| contains the absolute root directory. | ||
|
|
||
| category | ||
| A category assigned for organizing the documentation. | ||
|
|
||
| group | ||
| The namelist group that the variable is declared in. | ||
|
|
||
| valid_values | ||
| This is an optional attribute that is mainly useful for variables | ||
| that have only a small number of allowed values. It is a | ||
| comma-separated list of valid values for the variable. | ||
|
|
||
| desc | ||
| This is a text description of the variable including its | ||
| purpose and use. | ||
|
|
||
| values | ||
| This is a grouping of all the cases where a value can be | ||
| assigned with the namelist generator has been run. | ||
|
|
||
| value | ||
| Each <value> tag specifies a case where a value is assigned | ||
| to this variable when the namelist generator is run. If the | ||
| tag has no attributes, it is a default value. In general, | ||
| the namelist generator attempts to find a value with the | ||
| maximium number of attribute matches (and no non-matches). | ||
|
|
||
| standard_name | ||
| This is the CCPP Standard Name of the variable | ||
|
|
||
| units | ||
| This is the CCPP unit specification of the variable (e.g., m s-1). | ||
| --> | ||
| <entry id="eddy_lbulk_max"> | ||
| <type>real</type> | ||
| <kind>kind_phys</kind> | ||
| <category>pbl</category> | ||
| <group>eddy_diff_nl</group> | ||
| <standard_name>maximum_master_length_scale_for_eddy_diffusion</standard_name> | ||
| <units>m</units> | ||
| <desc> | ||
| Maximum master length scale designed to address issues in diag_TKE (the Bretherton-Park scheme) outside the boundary layer. In order not to disturb turbulence characteristics in the lower troposphere, this should be set at least larger than a few km. However, this does not significantly improve the values outside of the boundary layer. Smaller values make some improvement, but it is also noisy. Better results are seen using eddy_leng_max or kv_freetrop_scale. | ||
| Default: 40000 m | ||
| </desc> | ||
| <values> | ||
| <value>40.D3</value> | ||
| </values> | ||
| </entry> | ||
|
|
||
| <entry id="eddy_leng_max"> | ||
| <type>real</type> | ||
| <kind>kind_phys</kind> | ||
| <category>pbl</category> | ||
| <group>eddy_diff_nl</group> | ||
| <standard_name>maximum_dissipation_length_scale_for_eddy_diffusion</standard_name> | ||
| <units>m</units> | ||
| <desc> | ||
| Maximum dissipation length scale designed to address issues with diag_TKE (the Bretherton-Park scheme) outside the boundary layer, where the default value generates large diffusivities. A value of 30 m is consistent with the length scales used in the HB scheme; however, this will also reduce value in the boundary layer. | ||
| Default: 40000 m | ||
| </desc> | ||
| <values> | ||
| <value>40.D3</value> | ||
| <!-- waccm: 100.D0 --> | ||
| </values> | ||
| </entry> | ||
|
|
||
| <entry id="eddy_max_bot_pressure"> | ||
| <type>real</type> | ||
| <kind>kind_phys</kind> | ||
| <category>pbl</category> | ||
| <group>eddy_diff_nl</group> | ||
| <standard_name>air_pressure_threshold_for_maximum_turbulent_length_scale_application</standard_name> | ||
| <units>hPa</units> | ||
| <desc> | ||
| Bottom pressure level at which namelist values for eddy_leng_max and eddy_lbulk_max are applied. Default values are used at lower levels (i.e. the boundary layer). | ||
| Default: 100.D3 hPa | ||
| </desc> | ||
| <values> | ||
| <value>100.D3</value> | ||
| <!-- waccm: 100.D0 --> | ||
| </values> | ||
| </entry> | ||
|
|
||
| <entry id="eddy_moist_entrain_a2l"> | ||
| <type>real</type> | ||
| <kind>kind_phys</kind> | ||
| <category>pbl</category> | ||
| <group>eddy_diff_nl</group> | ||
| <standard_name>tunable_parameter_for_moist_entrainment_enhancement_in_pbl</standard_name> | ||
| <units>1</units> | ||
| <desc> | ||
| Moist entrainment enhancement parameter. Default: 30.D0 | ||
| </desc> | ||
| <values> | ||
| <value>30.D0</value> | ||
| </values> | ||
| </entry> | ||
|
|
||
| <entry id="eddy_wstarent"> | ||
| <type>logical</type> | ||
| <category>pbl</category> | ||
| <group>eddy_diff_nl</group> | ||
| <standard_name>use_wstar_entrainment_closure_formulation_for_eddy_diffusion_scheme</standard_name> | ||
| <units>flag</units> | ||
| <desc> | ||
| Use wstar (.true.) or TKE (.false.) entrainment closure in UW eddy diffusion scheme. | ||
| Default: TRUE | ||
| </desc> | ||
| <values> | ||
| <value>.true.</value> | ||
| </values> | ||
| </entry> | ||
|
|
||
|
|
||
|
|
||
| </entry_id_pg> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.