CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372
Open
jimmielin wants to merge 12 commits into
Open
CCPPize prescribed volcanic aerosol (prescribe_volcaero)#372jimmielin wants to merge 12 commits into
jimmielin wants to merge 12 commits into
Conversation
This was referenced Mar 12, 2026
to cherry-pick: remove constituent diag in prescribe_volcanic_aerosol
3e1155e to
9b8852d
Compare
nusbaume
requested changes
May 10, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for bringing this in @jimmielin! I have some change requests but hopefully nothing major, and of course if you have any questions or concerns with any of my requests then just let me know. Thanks again!
nusbaume
approved these changes
May 11, 2026
Collaborator
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for implementing my requests @jimmielin! I believe you'll need to remove const_props from the metadata file, but otherwise everything looks good to me now. Thanks again!
cacraigucar
requested changes
May 13, 2026
cacraigucar
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin
Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
prescribed_volcaero; will NOT go back to CAM since thetracer_datainterface is differentfilename_forstandard names tofilename_offor rule complianceList all namelist files that were added or changed:
A schemes/chemistry/prescribed_volcanic_aerosol_namelist.xml
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
New physics package for the tracer data test.
If yes to the above question, describe how this code was validated with the new/modified features:
Updated snapshot; tested with CAM snapshot for correctness