Skip to content

Complete CCPPization of Beljaars orographic form drag scheme#396

Open
jimmielin wants to merge 2 commits into
ESCOMP:mainfrom
jimmielin:hplin/beljaars
Open

Complete CCPPization of Beljaars orographic form drag scheme#396
jimmielin wants to merge 2 commits into
ESCOMP:mainfrom
jimmielin:hplin/beljaars

Conversation

@jimmielin
Copy link
Copy Markdown
Member

Tag name (The PR title should also include the tag name):
Originator(s):

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:
A schemes/beljaars_drag/beljaars_drag_namelist.xml

List all files eliminated and why:

List all files added and what they do:

A       test/test_suites/suite_beljaars_form_drag.xml
  - test SDF
 
A       schemes/beljaars_drag/beljaars_drag.F90
A       schemes/beljaars_drag/beljaars_drag.meta
A       schemes/beljaars_drag/beljaars_drag_interstitials.F90
A       schemes/beljaars_drag/beljaars_drag_interstitials.meta
  - Beljaars orographic form drag scheme, necessary interestitials
  - interstitials split off so beljaars_drag.F90 scheme can have a namelist attached to it

A       schemes/sima_diagnostics/beljaars_drag_diagnostics.F90
A       schemes/sima_diagnostics/beljaars_drag_diagnostics.meta
  - diagnostics scheme

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status main...<your_branch_name>)

M       schemes/vertical_diffusion/diffusion_solver.meta
M       schemes/vertical_diffusion/diffusion_stubs.F90
M       schemes/vertical_diffusion/diffusion_stubs.meta
  - moved formerly Beljaars interstitials to beljaars_drag_interstitials:
    beljaars_add_wind_damping_rate_run, beljaars_add_updated_residual_stress_run

M       to_be_ccppized/error_messages.F90
  - fix stray tab to get rid of compiler warning

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
No
New physics package, CAM regression tests, CAM-SIMA snapshot all pass

If yes to the above question, describe how this code was validated with the new/modified features:

@jimmielin jimmielin self-assigned this May 14, 2026
@jimmielin jimmielin added the enhancement New feature or request label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

CCPPize beljaars_drag

1 participant