-
Notifications
You must be signed in to change notification settings - Fork 220
Add cupid to preview namelists #4949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ekluzek
wants to merge
2
commits into
ESMCI:master
Choose a base branch
from
ekluzek:add_cupid_to_preview_namelists
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -109,6 +109,39 @@ def create_namelists(self, component=None): | |
| component, models | ||
| ) | ||
| ) | ||
| # | ||
| # Run any namelists for the post-processing component if it exists | ||
| # | ||
| # NOTE: This bit is copied from Case.flush | ||
| # TODO: make it a little function? | ||
| run_postprocess = self.get_value("RUN_POSTPROCESSING") | ||
| if run_postprocess: | ||
| _postprocessing_spec_file = self.get_value("POSTPROCESSING_SPEC_FILE") | ||
| if _postprocessing_spec_file is not None: | ||
| have_postprocessing = os.path.isfile(_postprocessing_spec_file) | ||
| else: | ||
| have_postprocessing = False | ||
|
|
||
| # Run buildnml for the post-processing component if buildnml exists | ||
| # NOTE: This copies the handling of buildnml for components in the section above | ||
| # TODO: Make it into a little subroutine? | ||
| if have_postprocessing: | ||
| config_dir = os.path.dirname(_postprocessing_spec_file) | ||
| cmd = os.path.join(config_dir, "buildnml") | ||
| if ( os.path.exists(cmd) ): | ||
| # NOTE: In order to name the specific postprocessing component, there would need to be | ||
| # a new XML variable with something like POSTPROC_NAME | ||
| compname = "postprocessor" | ||
| logger.info("Create namelist for postprocessing component {}".format(compname)) | ||
| import_and_run_sub_or_cmd( | ||
| cmd, | ||
| (caseroot), | ||
| "buildnml", | ||
| (self, caseroot, compname), | ||
| config_dir, | ||
| compname, | ||
| case=self, | ||
| ) | ||
|
|
||
| # Save namelists to docdir | ||
| if not os.path.isdir(docdir): | ||
|
|
@@ -128,6 +161,7 @@ def create_namelists(self, component=None): | |
| "nuopc.runconfig", | ||
| "*streams*txt*", | ||
| "*streams.xml", | ||
| "*.yml", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The CUPiD config yaml files should be copied to the CaseDocs subdirectory to keep the record of what they are doing. |
||
| "*stxt", | ||
| "*maps.rc", | ||
| "*cism*.config*", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We plan to add POSTPROCESSING_TOOL_NAME to the CUPiD confit_tool.xml file which will set the specific name of the postprocessing tool (just like components set their names). Here we will get that variable and then set compname to it.