Slab force update by The9Cat · Pull Request #215 · EXP-code/EXP

The9Cat · 2026-04-05T19:38:27Z

Updates for consistency with the current conventions

Density for isothermal slab is now proportional to sech(z/2h)^2 rather than sech(z/h)^2
SlablSL now implements the self_consistent flag for enabling a frozen potential
Added a version # to the slab cache along with a user warning about this change

One general development support feature

Added compile -time parsing of the EXP version string into major, minor, patch for internal version control logic. E.g.

#include <iostream>
#include "libvars.H"
using namespace __EXP__;

int main()
{
  std::cout << "Major=" << exp_build.major << '\n';
  std::cout << "Minor=" << exp_build.minor << '\n';
  std::cout << "Patch=" << exp_build.patch << '\n';
  return 0;
}

This will make future version-dependent toggles easier to implement. We have a usage example in both SLGridSlab and in utils/Test.

…ency with the recent Cylinder update

Copilot

Pull request overview

This PR updates the slab force/basis implementation to match current conventions (isothermal slab profile normalization, cache versioning, and a self_consistent “frozen potential” mode) and adds compile-time parsing of the EXP version string for internal version-dependent logic.

Changes:

Switch isothermal slab model normalization to use a sech^2(z/2H) form and warn users when running older EXP versions.
Add a self_consistent configuration flag to SlabSL to support freezing the potential coefficients.
Add compile-time EXP version parsing (EXPversion.H, exp_build) and a small test utility; add slab cache version attribute.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
utils/Test/version_test.cc	Adds a small example program that prints `VERSION` and parsed major/minor/patch.
utils/Test/CMakeLists.txt	Builds the new `vtest` utility.
utils/ICs/bonnerebert.cc	Removes the local `VERSION` macro and the `-V` version flag handling.
src/SlabSL.H	Documents `self_consistent` and adds storage for frozen coefficients.
src/SlabSL.cc	Adds YAML parsing for `self_consistent` and uses frozen coefficients during force evaluation.
src/cudaSlabSL.cu	Uses frozen coefficients when copying coefficients to the GPU if `self_consistent=false`.
include/SLGridMP2.H	Adds cache versioning for slab cache and improves internal grouping/comments.
include/libvars.H	Exposes `exp_build` as a compile-time parsed `{major,minor,patch}` version triple.
include/EXPversion.H	Introduces a constexpr version-string parser.
exputil/SLGridMP2.cc	Updates isothermal slab profile functions and adds slab cache version checks/write.
exputil/libvars.cc	Ensures config header is included in libvars translation unit.
expui/BiorthBasis.cc	Allows `self_consistent` as a recognized YAML key for the slab basis config.

Comments suppressed due to low confidence (1)

utils/ICs/bonnerebert.cc:404

The -V/--version option was removed from getopt_long parsing, but long_options still defines a version entry and usage() still advertises -V. This makes the CLI help incorrect and --version will likely behave unexpectedly (depending on getopt_long behavior). Either restore handling for -V/--version or remove it consistently from long_options and the usage text.

			   "R:"	/* runit   */
			   "N:"	/* number  */
			   "S:"	/* seed    */
			   "h", /* help    */
			   long_options, (int *) 0)) != EOF)
    {
      switch (c)
	{
	case 'o':		/* --output */
	  oname = string(optarg);
	  break;
	case 'd':		/* --xstep */
	  h = atof(optarg);
	  break;
	case 'r':		/* --ratio */
	  Rratio = atof(optarg);
	  break;
	case 'R':		/* --runit */
	  R = atof(optarg);
	  break;
	case 'M':		/* --munit */
	  Munit = atof(optarg);
	  break;
	case 'm':		/* --mass */
	  M = atof(optarg);
	  break;
	case 'T':		/* --temp */
	  T = atof(optarg);
	  break;
	case 'N':		/* --number */
	  N = atoi(optarg);
	  break;
	case 'S':		/* --seed */
	  S = atoi(optarg);
	  break;
	case 'h':
	  usage (0);

	default:
	  usage (-1);
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

The9Cat · 2026-04-05T21:08:19Z

@michael-petersen I am probably the only one that uses the slab stuff and these changes implement some of the standard features from the other force classes. So no need for you to spend time on most of this. It's all tested and seems to work.

However, note that this PR adds a compile-time function that parses the CMake-generated VERSION string into a structure of three ints (major, minor, patch) that may be used to gate various features rather than reverting to some sort of on-the-fly parse of the VERSION for each case or using CPP macros (yuck). The structure, named EXPversion, is a global library variable compiled into exputil. E.g. this PR uses the EXPversion instance to alert the user to the scale height convention change for the the isothermal disk. Your comments on this bit will be helpful I think.

Agent-Logs-Url: https://github.com/EXP-code/EXP/sessions/a9b4ee92-2327-4580-968b-23dded26f6e2 Co-authored-by: The9Cat <25960766+The9Cat@users.noreply.github.com>

Copilot · 2026-04-05T21:13:15Z

@michael-petersen I am probably the only one that uses the slab stuff and these changes implement some of the standard features from the other force classes. So no need for you to spend time on most ...

The version_test.cc file now consistently uses "integer triplet" in both the file comment and the runtime output (commit b7ed7eb). The other resolved review comments were already addressed in earlier commits on this branch.

…th SLGridSph and provenance policy

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The9Cat · 2026-05-03T14:52:07Z

+    @details **YAML configuration**
+
+    @param nmaxx is the maximum order of the expansion in x (default 6)
+
+    @param nmaxy is the maximum order of the expansion in y (default 6)
+
+    @param nmaxz is the maximum order of the expansion in z (default 6)
+
+    @param nminx is the minimum order of the expansion in x (default 0)
+
+    @param nminy is the minimum order of the expansion in y (default 0)
+
+    @param hslab is the scale height of the slab (default 0.2)
+
+    @param zmax is the maximum z for the slab (default 10.0)
+
+    @param ngrid is the number of grid points in z for the
+    Sturm-Liouville solver (default 1000)
+
+    @param cmap is the coordinate mapping for the SL solver (must be one of "tanh", "sech", or "linear", default "linear")
+
+    @param type is the type of slab to solve for (default
+    "isothermal", must be "isothermal", "parabolic", or "constant")
+
+    @param self_consistent set to true allows the particles to evolve
+    under the time-dependent basis expansion. For a basis fixed in time to
+    the initial time: set to false.
+
+    @param cachename is the name of the basis cache file.  This is a
+    required parameter.
+*/
