Skip to content

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Dec 9, 2025

This pull request updates the project to target .NET 10.0, replaces the legacy .sln solution file with a new .slnx format, and updates the CI workflow to use the new solution and .NET version. It also removes compatibility with .NET 6.0 and cleans up conditional dependencies and obsolete code.

.NET Version and Target Framework Updates:

  • Updated all project files (.csproj) to target .NET 10.0 instead of .NET 8.0, and removed .NET 6.0 from EasyNetQ.Management.Client targets. [1] [2] [3] [4]
  • Updated the CI workflow (.github/workflows/ci.yml) to use .NET SDK 10.x and test/build against .NET 10.0. [1] [2] [3] [4] [5]

Solution Structure Changes:

  • Removed the old Visual Studio .sln solution file and replaced it with a new .slnx solution format to reflect the updated project structure. [1] [2]
  • Updated all references in CI scripts to use the new .slnx solution file. [1] [2] [3] [4]

Dependency and Code Cleanup:

  • Made System.Text.Json a conditional dependency for only the net48 target in the test project, preventing unnecessary references for .NET 10.0.
  • Removed the obsolete JsonNumberEnumConverter implementation, which is no longer needed for .NET 8.0 or greater.

@inikulshin
Copy link
Contributor

Imo, the condition

#if !NET8_0_OR_GREATER && !NETSTANDARD2_0

made JsonNumberEnumConverter to be used for .NET Framework

@WeihanLi WeihanLi changed the title remove net6.0 and add net10.0 remove net6.0 and update tests to net10.0 Dec 26, 2025
@WeihanLi
Copy link
Contributor Author

WeihanLi commented Dec 26, 2025

Imo, the condition

#if !NET8_0_OR_GREATER && !NETSTANDARD2_0
made JsonNumberEnumConverter to be used for .NET Framework

I think it's for .NET 6 target since the project targets for netstandard2.0;net6.0;net8.0, and for .NET Framework, it already references the System.Text.Json package

@WeihanLi WeihanLi marked this pull request as ready for review December 26, 2025 13:36
Copilot AI review requested due to automatic review settings December 26, 2025 13:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the test projects to .NET 10, removes .NET 6.0 support from the main library, and modernizes the solution structure by migrating to the .slnx format. The changes also remove obsolete JSON serialization code that's no longer needed with the updated framework targets.

  • Removed .NET 6.0 target framework from the main library project (now targets netstandard2.0 and net8.0)
  • Updated all test projects from net8.0 to net10.0
  • Replaced legacy .sln file with modern .slnx format and updated all CI workflow references

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Source/EasyNetQ.Management.Client/EasyNetQ.Management.Client.csproj Removed net6.0 from target frameworks, keeping netstandard2.0 and net8.0 for library compatibility
Source/EasyNetQ.Management.Client/Serialization/JsonNumberEnumConverter.cs Removed custom enum converter no longer needed after dropping net6.0 support
Source/EasyNetQ.Management.Client.Tests/EasyNetQ.Management.Client.Tests.csproj Updated test framework from net8.0 to net10.0; made System.Text.Json conditional for net48 only
Source/EasyNetQ.Management.Client.IntegrationTests/EasyNetQ.Management.Client.IntegrationTests.csproj Updated test framework from net8.0 to net10.0
Source/EasyNetQ.Management.Client.ApprovalTests/EasyNetQ.Management.Client.ApprovalTests.csproj Updated test framework from net8.0 to net10.0
Source/EasyNetQ.Management.Client.slnx Added new XML-based solution file format with project and folder structure
Source/EasyNetQ.Management.Client.sln Removed legacy solution file format
.github/workflows/ci.yml Updated .NET SDK to 10.x, changed all solution file references from .sln to .slnx, and updated framework matrix to net10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants