add support for secondary text on select items#1883
Merged
jallen-cyber merged 4 commits intomainfrom Apr 9, 2026
Merged
Conversation
Contributor
Author
screenshot from Storybook |
jallen-cyber
force-pushed
the
SHPE-1203-FlexRate-Drop-Down-SubText
branch
from
6221cf6 to
e250c52
Compare
OskiTheCoder
reviewed
Apr 8, 2026
| const captionText = showHelperText ? helperText : errorText; | ||
| const selectedDescription = ( | ||
| selectState.selectedItem?.props as { description?: ReactNode } | undefined | ||
| )?.description; |
Member
There was a problem hiding this comment.
question: is it possible to render the descriptive secondary text without passing isDescriptive to Select?
Contributor
Author
There was a problem hiding this comment.
Thanks for catching that it ended up being dead code after my final changes
jallen-cyber
force-pushed
the
SHPE-1203-FlexRate-Drop-Down-SubText
branch
from
fe423fb to
0e2dce2
Compare
jallen-cyber
force-pushed
the
SHPE-1203-FlexRate-Drop-Down-SubText
branch
from
0e2dce2 to
6502f0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Changes
Please provide a brief summary of the changes made and why they were made.
Include any notes, screenshots, or videos that may be helpful for developers reviewing this pull request.
✅ Checklist
Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:
Strikethroughany items that are not applicable to this pull request.