Fixed bugged to claim the lottery rewards #5
Open
0xStalin-eth wants to merge 3 commits into
Open
Conversation
If the reamining ETH on the victim contract is less than the ETH the reentrant call will take, an error will occur, and all the changes will be reverted! The reamining ETH balance on the victim contract must be greater than the ETH that will be taken in the next reentrant call, otherwise, an error will occur and all the contract's interaction changes will be reverted /// Error: VM Exception while processing transaction: reverted with reason string 'Address: unable to send value, recipient may have reverted'
Previously there was no way to claim the rewards of the lottery. The winner will be set to the attacker contract address, hence, if the attacker contract doesn't call the withdrawPrize() function, the funds will be stuck forever (unless there is another winner, but that is a different scenario...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.