Fix critical password recovery security vulnerabilities and enhance validation#12
Draft
Fix critical password recovery security vulnerabilities and enhance validation#12
Conversation
Author
|
@joao-pedro01 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
❌ Deploy Preview for ecovoucher failed.
|
Co-authored-by: joao-pedro01 <80638211+joao-pedro01@users.noreply.github.com>
Co-authored-by: joao-pedro01 <80638211+joao-pedro01@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Recuperação e redefinição de senha (com token futuro)
Fix critical password recovery security vulnerabilities and enhance validation
Sep 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses critical security vulnerabilities in the password recovery system that were preventing users from logging in after password resets, along with several other security and consistency improvements.
Critical Security Fix: Password Double-Hashing
The most critical issue was in the User and Company model pre-save hooks, which were hashing passwords on every save operation, not just when passwords were new or modified. This caused a dangerous double-hashing scenario:
Impact: Users who reset their passwords couldn't log in because the system was comparing plain passwords against double-hashed values, causing authentication to always fail.
Token Expiration Consistency
Fixed inconsistent token expiration times that were causing confusion:
Enhanced Password Validation
Added robust password strength requirements to the reset password endpoint:
alterarSenhavalidationSecurity Improvements
validateTokenendpoint to check and clean expired tokensTesting and Documentation
Affected Endpoints
POST /api/user/auth/recuperar-senha- Request password resetGET /api/user/auth/validar-token/:token- Validate reset tokenPOST /api/user/auth/redefinir-senha- Reset password with tokenThis fix ensures the password recovery system works correctly for both individual users (PF) and companies (PJ), addressing the testing requirements mentioned in the issue comments.
Fixes #11.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.