This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Checking if the VM is actually shut down already#6
Open
CJFWeatherhead wants to merge 2 commits intoEdGeraghty:v3-Refactorfrom
Open
Checking if the VM is actually shut down already#6CJFWeatherhead wants to merge 2 commits intoEdGeraghty:v3-Refactorfrom
CJFWeatherhead wants to merge 2 commits intoEdGeraghty:v3-Refactorfrom
Conversation
Might be a cleaner way of doing this, but you get the idea
EdGeraghty
reviewed
Dec 28, 2019
| (( pullPlug-- )); | ||
| sleep 1; | ||
| done; | ||
| if sudo -u vboxuser_"${vm}" VBoxManage showvminfo "${vm}" --machinereadable | grep running |
Owner
There was a problem hiding this comment.
Use vmRunning "${vm}" here as per L25 - if vmRunning doesn't do what you need, gimme a pull request :)
Merry Christmas, btw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be a cleaner way of doing this, but you get the idea